Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IFC-569: infer hfid from single-attribute uniqueness constraint #4352

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

ajtmccarty
Copy link
Contributor

@ajtmccarty ajtmccarty commented Sep 12, 2024

fixes #4174
fixes #4181
IFC-569
IFC-581

IFC-569

update schema processing so that if a schema DOES NOT have a human_friendly_id defined and DOES have a uniqueness_constraint that includes a single attribute, set the human_friendly_id to use that attribute
this is basically what we do if there is no human_friendly_id, but there is an attribute that is set to unique=True

for example

SchemaA:
  uniqueness_constraints: [["name__value"]]
  human_friendly_id: null

would become

SchemaA:
  uniqueness_constraints: [["name__value"]]
  human_friendly_id: ["name__value"]

IFC-581

update schema validation so that a uniqueness constraint that consists of a single attribute can be used to consider an attribute unique when it comes to validating that the human-friendly ID includes a unique attribute

@ajtmccarty ajtmccarty requested a review from a team September 12, 2024 23:15
@github-actions github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label Sep 12, 2024
@ajtmccarty ajtmccarty merged commit fc7ca63 into stable Sep 13, 2024
45 checks passed
@ajtmccarty ajtmccarty deleted the ajtm-09122024-hfid-generate-IFC-569 branch September 13, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group/backend Issue related to the backend (API Server, Git Agent)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants